Faster matrix sqrt for upper triangular matrices. #31100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Feb 18, 2019
|
No problem, I'll make a PR in BaseBenchmarks for this issue. |
mateuszbaran
added a commit
to mateuszbaran/BaseBenchmarks.jl
that referenced
this pull request
Feb 18, 2019
For tracking potential regressions to JuliaLang/julia#31100 .
mateuszbaran
added a commit
to mateuszbaran/BaseBenchmarks.jl
that referenced
this pull request
Feb 18, 2019
For tracking potential regressions to JuliaLang/julia#31100 .
|
@mateuszbaran Could you please rebase this PR, and when tests pass, I'll merge. Or has this been fixed by type inference improvements by now? |
|
I've actually forgotten about this PR. I will check if this is still relevant. |
Replacing Val(::Bool) in an argument list with an explicit if makes the call type stable. The issue was discussed in JuliaLang#31007.
mateuszbaran
force-pushed
the
mbaran/faster-matrix-sqrt
branch
from
f1f6857
to
9075235
Compare
|
OK, this still looks relevant, there is a similar difference in performance on 1.4.1 and a 44 day old Julia master I had around. I think my branch is rebased now. |
|
Sorry to bother you again, but can you rebase again. It's not your fault, but you rebased onto a commit that had a whitespace issue. |
|
Nevermind, I'll just merge. The whitespace issue is resolved on master, and this PR doesn't touch the file in question. |
|
OK, thanks 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing Val(::Bool) in an argument list with an explicit if makes the
call type stable. The issue was discussed in #31007.